Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-2192: Build macOS universal2 binaries with ARM64 (Apple Silicon) support #2423

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

phw
Copy link
Member

@phw phw commented Apr 22, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

This updates the build for macOS to produce universal2 fat binaries, that combine the code for Intel and ARM64 CPUs.

Solution

Specify "universal" as architecture in PyInstaller spec. Use universal2 binaries libdiscid and compile PIP packages PyYAML and charset-normalizer.

TODO:

  • The Qt6 binaries are single arch only. We need some solution for this. One option will be to download both the arm64 and x86_64 variants of the PyQt6_Qt6 package from PyPI and combine the binaries locally.
  • Qt6 should generally be upgraded to 6.6, as there are some runtime issues with the currently used 6.5 (e.g. global menu does not open). But this is handled in Build with Qt 6.7.0 on windows and macos #2420, but unfortunately there are some CI issues to solve.

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Testing on macOS with both Intel and ARM chips

@phw phw marked this pull request as draft April 22, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant